view · edit · sidebar · attach · print · history

Index>

20151111-fi-changelog

Summary

  • Fix import-daily
  • Snap-Back for FI diff is not correct
  • update_textinfo_swissmedicinfo --reparse looses old change logs
  • RSS of fachinfo does not work under chrome. Firefox does not show all changes

Commits

Index

Keep in Mind for work to do
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
  • Import via data/medreg_companies.yaml
  • Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
  • Fix galenic_forms when parsing swissmedic.xlsx
  • Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
  • Get updated ATC-codes from EPha for oddb.org, too.
  • Use refdatabase for oddb.org, too.
  • Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
  • When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.

Fix import-daily

Got the following error 

Plugin: ODDB::TextInfoPlugin
Error: NotImplementedError
Message: method `method_missing' called on unexpected T_NODE object (0x00000007ff0698 flags=0x21c klass=0x0)
Backtrace:
/var/www/oddb.org/src/view/chapter.rb:181:in `to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/divcomposite.rb:42:in `block (3 levels) in to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/divcomposite.rb:40:in `each'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/divcomposite.rb:40:in `inject'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/divcomposite.rb:40:in `block (2 levels) in to_html'
(eval):373:in `div'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/divcomposite.rb:39:in `block in to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/divcomposite.rb:38:in `each'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/divcomposite.rb:38:in `each_with_index'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/divcomposite.rb:38:in `to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:102:in `block in component_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:100:in `each'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:100:in `component_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:119:in `block in to_html'
(eval):1290:in `td'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:118:in `to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:155:in `block in field_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:153:in `each'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:153:in `field_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:144:in `block in to_html'
(eval):1256:in `tr'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:143:in `to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:295:in `block (2 levels) in to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:295:in `collect'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:295:in `block in to_html'
(eval):769:in `table'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/grid.rb:294:in `to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/composite.rb:266:in `to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/template.rb:123:in `block in to_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/template.rb:116:in `call'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/template.rb:116:in `template_tags'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/template.rb:111:in `block (2 levels) in template_html'
(eval):1086:in `body'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/template.rb:110:in `block in template_html'
/usr/local/lib/ruby/1.9.1/cgi/html.rb:432:in `block in html'
(eval):1069:in `html'
/usr/local/lib/ruby/1.9.1/cgi/html.rb:432:in `html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/template.rb:109:in `template_html'
/usr/local/lib/ruby/gems/1.9.1/gems/htmlgrid-1.0.6/lib/htmlgrid/template.rb:122:in `to_html'
/var/www/oddb.org/src/view/rss/fachinfo.rb:72:in `block (2 levels) in to_html'
/var/www/oddb.org/src/view/rss/fachinfo.rb:50:in `each'
/var/www/oddb.org/src/view/rss/fachinfo.rb:50:in `block in to_html'
/usr/local/lib/ruby/1.9.1/rss/maker/base.rb:438:in `make'
/usr/local/lib/ruby/1.9.1/rss/maker/base.rb:402:in `make'
/usr/local/lib/ruby/1.9.1/rss/maker.rb:9:in `make'
/var/www/oddb.org/src/view/rss/fachinfo.rb:40:in `to_html'
/var/www/oddb.org/src/plugin/plugin.rb:84:in `block (2 levels) in update_rss_feeds'
/var/www/oddb.org/src/plugin/plugin.rb:83:in `open'
/var/www/oddb.org/src/plugin/plugin.rb:83:in `block in update_rss_feeds'
/var/www/oddb.org/src/plugin/plugin.rb:47:in `call'
/var/www/oddb.org/src/plugin/plugin.rb:47:in `block in l10n_sessions'
/var/www/oddb.org/src/plugin/plugin.rb:44:in `each_key'
/var/www/oddb.org/src/plugin/plugin.rb:44:in `l10n_sessions'
/var/www/oddb.org/src/plugin/plugin.rb:75:in `update_rss_feeds'
/var/www/oddb.org/src/plugin/text_info.rb:120:in `postprocess'
/var/www/oddb.org/src/plugin/text_info.rb:1483:in `import_swissmedicinfo'
/var/www/oddb.org/src/util/updater.rb:573:in `block in update_notify_simple'
/var/www/oddb.org/src/util/updater.rb:549:in `call'
/var/www/oddb.org/src/util/updater.rb:549:in `wrap_update'
/var/www/oddb.org/src/util/updater.rb:567:in `update_notify_simple'
/var/www/oddb.org/src/util/updater.rb:344:in `update_textinfo_swissmedicinfo'
/var/www/oddb.org/src/util/updater.rb:197:in `run'
jobs/import_daily:13:in `block in <module:Util>'
/var/www/oddb.org/src/util/job.rb:40:in `call'
/var/www/oddb.org/src/util/job.rb:40:in `run'
jobs/import_daily:12:in `<module:Util>'
jobs/import_daily:11:in `<module:ODDB>'
jobs/import_daily:10:in `<main>'

Must reload thinpowers database as I could not reproduce the error here. There are several other occurrences with T_NODE-problems in RSS, eg. see

Before working. Saving current state of work (patch). Attach:Don-t-add-duplicated-changelog-entries.txt

Looks like that I forgot to restart the fiparse service after pulling the changes yesterday.

Snap-Back for FI diff is not correct

Zeno wants the following fixes:

  1. Must display a better text than "ODDB::FachinfoDocument::ChangeLogItem"
  2. When selecting a diff of a given date it must be possible to go back to the list of all diffs (Currently it goes back one more step)
  3. Change "Liste der Änderungen (ab November 2015) an der Fachinformation zu 65569 Elizette 30" to "Liste der Änderungen an der Fachinformation zu Elizette 30 (Swissmedic-Nr. 65569)"
  4. Text above should go into the snapback
  5. List of changes should show chapter title
  6. Snapback of http://ch.oddb.org/de/gcc/show/fachinfo/65569/diff should look like "Sie befinden sich in - Home - Fachinfo - Liste der Änderungen der Fachinformation zu Elizette 30 (Swissmedic-Nr. 65569)" after having clicked on a diff it must look like "Sie befinden sich in - Home - Fachinfo - Liste der Änderungen der Fachinformation zu Elizette 30 - Diff vom 10.11.2015 (Swissmedic-Nr. 65569)" and in the
    1. In dark green title it must show "74 Änderungen an Fachfinfo Elizette 30"
  7. Date format must be tt.mm.yyyy
  8. Fix type "Fachfinfo" => "Fachinfo"
  9. Via Bread-Crumbs it must always be possible to go back to the last visited view

Changing the date format to use european date, needed changes in src/util/session.rb and src/view/drugs/fachinfo_change_logs.rb

Looking at http://dev.ywesee.com/Masa/20110810-migel-search-oddbOrg.

Okay for fachinfos the problem is even more complicated as the pointer_descr is given with a FachinfoWrapper in src/state/drugs/fachinfo.rb. I must probably use the same trick for the change_logs. Okay, got some progress. The last in the snapback list is okay for http://oddb-ci2.dyndns.org/de/gcc/show/fachinfo/63171/diff "Änderungen" and http://oddb-ci2.dyndns.org/de/gcc/show/fachinfo/63171/diff/10.11.2015 (10.11.2015). But why does it not get expanded?

Views look better (except that snapback is still missing intermediate entries). Screenshots are (found via search by IKSNR 65569)

Corrected various problems. Snapback works not well wenn coming via search as the info is too long as "Diff vom 10.11.2015 (Swissmedic-Nr. 63171)", "Liste der Änderungen an der Fachinformation zu Desofemine 20 Nova (Swissmedic-Nr. 63171)" and "Fachinformation zu Elizette 30" don't fit on one line. Also it does not interact well neither when coming from the Home "Fachinfo-Online" nor from a search. But this will be fixed next week.

Pushed the commits

update_textinfo_swissmedicinfo --reparse looses old change logs

Problems are:

RSS of fachinfo does not work under chrome. Firefox does not show all changes

Added a test for the rss-feeds when running under firefox.

view · edit · sidebar · attach · print · history
Page last modified on November 12, 2015, at 08:07 AM