20151123-snapback
Summary
- Snap-Back for FI diff is not correct
Commits
Index
Snap-Back for FI diff is not correct
- Keep in Mind for work to do
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Use refdatabase for oddb.org, too.
- Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
- When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
- Order of entering search type and value should not matter. Both should show long URL with search
Snap-Back for FI diff is not correct
Must make the snapback work with the new watir tests. Then will have a look whether we could remove the state_id from the URL.
Found nothing about breakcrumb/snapback in doc/resources/javascript/*.js. Looking at commits which have snapback in their comment. Must understand VOLATILE in sbsm. Looks like we have volatile and other states, which affect navigation. Puttings some debug info into view/pointersteps to be able to follow the different paths. Some views declare SYMBOL_MAP -> PointerLink. DIRECT_EVENT is initialized to stuff like :home_pharmacies, :home_drugs. To what should we initialize it when we come from /de/gcc and clicking on a link inside Fachinfo-Online?
Discussing with Zeno we agreed, that /home_drugs is the same as /home. /home is also the link we follow when clicking on the logo. "Sie befinden sich in" points to the home of the zone, e.g home_hospitals. If you entered it via it changes to "Suchresultat" and points to /result/
I think the best solution would be to able display snapback (search, then fi, then changes, then details) to display
Sie befinden sich - Home - 65569 - 01 -001 - Fachinformation - Änderungen - 10.11.2015
After having entered a swissmedic# and set the search_type to swissmedic (or the other was round), we should arrive in not in /de/gcc/search/zone/drugs/search_query/58392/search_type/st_registration?#best_result, nor in http://ch.oddb.org/de/gcc/show/state_id/236092420/reg/58392/seq/01/pack/001, but in /de/gcc/show/reg/58392/seq/01/pack/001. This last URL display Sie befinden sich in - MiGeL-Home - 58392 - 01 which is also incorrect.
But first I attack the problem, when we come from a link from the Fachinfo-Online. After clicking on the first one, I arrive at /de/gcc/fachinfo/swissmedicnr/54624. Here I would prefer the URL to be /de/gcc/show/fachinfo/5462, but this is a cleanup which I will reserve for later. The snapback displays "Sie befinden sich in - Home - Fachinformation zu Cosopt®/Cosopt-S® Monodosis", which should be shortened- It is okay that when clicking on a chapter, I stay with the same Snapback. After clicking on "Änderungen anzeigen" I arrive at /de/gcc/show/fachinfo/54624/diff. The URL is okay, but the display of "- Home - Liste der Änderungen an der Fachinformation zu Cosopt (Swissmedic-Nr. 54624)". Here I must have 3 elements in the snapback and not only two.
Should we display "Suchresultat" in the snapback or just switch show the content eg. the IKSNR, name, etc.
Defining DIRECT_EVENT = :fachinfo_search in the class State::Drugs::FachinfoDocumentChangelogs changes make http://oddb-ci2.dyndns.org/de/gcc/show/fachinfo/65569/diff display "Sie befinden sich in - FI erweitert - Liste der Änderungen an der Fachinformation zu Elizette 30 (Swissmedic-Nr. 65569)". Not exactly what intended.
Okay. The solutions lays that I must implement a method backtracking in the class ODDB::View::Drugs::FachinfoDocumentChangelogs and FachinfoDocumentChangelogItem.
Things look better. After selecting a Fachinfo via searching by swissmedic-nr I have in the snapback "Suchresultat", via Fachinfo-Online "Home". Afterwards I have now more elements. See
Will continue tomorrow to make the watir test pass with this example.