Index>
20151124-oddb2xml
Summary
- Fix COOL, QTY, ORPH entities
Commits
Index
- Keep in Mind for work to do
-
- Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
- I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
- The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
- creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
- Import via data/medreg_companies.yaml
- Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
- Fix galenic_forms when parsing swissmedic.xlsx
- Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
- Get updated ATC-codes from EPha for oddb.org, too.
- Use refdatabase for oddb.org, too.
- Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
- When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
- Order of entering search type and value should not matter. Both should show long URL with search
Fix COOL, QTY, QRPH entities
The following problem must be fixed.
Findings:
- COOL: This element should be emitted when it is found via the fridges. This does not seem to be working and there is no unit test to check for its presence.
- QTY: This is not present in oddb_article (only in oddb_product and oddb_calc), but mentioned in the xsd. Here the XSD should be fixed. Currently we use the same entity ARTICLE in oddb_calc.xml and oddb_article.xml, even when they are quite distinct. We should probably create a new definition for oddb_calc, e.g. SWISS_APPROVED_DRUG.
- ORPH is found the in the builder, but never checked in a spec. Must find out why this does not work.
Added failing spec-test for COOL and ORPH. Added the following GTINs to my list of DRUGS to be used for spec tests in spec/spec_helpers:
- '7680592670114',# fridge drug IKSNR 59267: Agrippal, Injektionssuspension
- '7680621320010',# orphan drug IKSNR 62132: Adcetris, Pulver zur Herstellung einer Infusionslösung
Running bundle exec rspec spec/builder_spec.rb:265 to download actual data and filter it automatically. This takes some time, as the Packungen.xml is very large.
After looking at the code I found out, that I changed once some variables from fridges/orphans to fridge/orphan, but not all. As I had no unit test, the failure did not get noticed. Also the column order in the used XLSX files has changed.
Running transpec to adapt all specs to the new expect syntax.
Pushed commits
Fixed the problem for the orphan flag. Unit test for fridge did not work, as in the file fridge there are only 16 products, as it is also the list of blood products and vaccines. Therefore must regenerate the vcr again, which take a few minutes.
Having again SSL-problems to connect to the medreg server. And now refilling the VCR cassettes has even more problems. Will solve these problems tomorrow. Also must check whether we have a test for each of the fields mentioned in the xsd files.