view · edit · sidebar · attach · print · history

Index>

20151216-oddb2xml-atc-prices

Summary

  • Check prices and atc-code of oddb2xml
  • Inconsistent styles with de/mobile lnf

Commits

Index

Keep in Mind for work to do
  • Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
  • I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
  • The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
  • creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
  • Import via data/medreg_companies.yaml
  • Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
  • Fix galenic_forms when parsing swissmedic.xlsx
  • Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
  • Get updated ATC-codes from EPha for oddb.org, too.
  • Use refdatabase for oddb.org, too.
  • Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
  • When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
  • Order of entering search type and value should not matter. Both should show long URL with search

Check prices and atc-code of oddb2xml

A attentive user has the following questions about oddb2xml.

  • Found 223 differences of ATC-Codes between another sources and those found in oddb2xml. 170 have the same first 4 characters
  • NBR_RECORD does not match count of elements
    • oddb_article.xml 170,643 elements, but NBR_RECORD is 170,673
    • oddb_product.xml 17,654 elements, but NBR_RECORD is 17,654
  • There seem to be 55‘562 article having the same price of 305.83 PRICEPEXF

Looking for an explanation for these facts. Let's start with the NBR_RECORD. Here is is clear, that we always just outputted the length of all known articles, even when we skip a few of them, eg. because they are for veterinary useage. Also we are missing a test for them. Correcting this. This take some time, as we 10 files containing NBR_RECORD and must add unit test for all of them.

Pushed commits Fixed calculating NBR_RECORD and Bumped version to 2.3.0

Attacking the problem with the wrong price 305.83. Looks like that omitting the pharmacode from the BAG Preparations.xml is causing this effect. Wie have 383 missing GTINs in Preparations.xml. Adding a debug outout for each.

Changes look good. Found 9247 occurences of PEXF in oddb_article.xml compared to 64835 in oddb_article.xml produced with version 2.2.8 of the oddb2xml gem. Preparations.xml has 9584 ExFactoryPrice. But in Preparations.xml we have also 383 missing GTINs. Looking at 7680536620137 (3TC) we find in oddb_article.xml (produced with the options -e -I80 the following prices:

  • PEXF 164.55
  • PPUB 205.3
  • ZURROSE 172.00
  • ZURROSEPUB 205.30
  • RESELLERPUB 309.6

These look sensible for me.

Found that I got two items Epimineral Granulat and Epimineral Paste without GTIN, Pharmacode in oddb2xml_files_nonpharma.xls. This error should be corrected to. ZurRose contains the following lines 

1125822801EPIMINERAL Paste 20 g                             0043200060004000000000000000000000001
1125830700EPIMINERAL Wundgranulat 6 g                       0043200060004000000000000000000000001

which means, that they have pharmacode of 830701 and 830700.

Changed code and tests to reject pharmacode 0. Pushed commits Bumped version to 2.3.1 to revert to spreadsheet 1.1.0 and Don't emit PEXF for drugs not listed with a GTIN in BAG Preparations.xml

Running test_options to see whether all is okay or not.

Working on removing the NON-Pharma.xls from oddb2xml_files. Pushed commit Deactivate (Pseudo-)Migel. Updated tests

Started test_options again.

Inconsistent styles with de/mobile lnf

When looking at the fachinfo on the iPhone various elements don't have the same size, e.g. "Stand. d Info" is too large and the company name "Helvepharm AG" is too small when looking at Propranolol/- retard Helvepharm. Looking at the style sheets used via chromium (started with chromium --profile-directory=/tmp/zzz http://i.ch.oddb.org/de/mobile/fachinfo/reg/47551).

The following differences were remarked between the td for Fachinformation zu Propranolol/- retard Helvepharm: and Helvepharm AG. The latter uses the css classes td right where the former has td. Don't know why the alignment changes the size.

Comparing the fields Überdos. and Stand d. Info. Has no differences (except the number of glyphs displayed) Attaching the 4 complete style description as seen by the chromium.

view · edit · sidebar · attach · print · history
Page last modified on December 16, 2015, at 05:04 PM