Index>

20151222-unit-test-ruby-2-x

Summary

• Remove support for reading PDF and make unit test pass under Ruby 2.x
• Cleanup fachinfo-rss

Commits

• https://github.com/ngiger/oddb.org/commit/92fc3c95d3807b02e171508668b09d31c7c0381b Removed unused link in fachinfo-RSS

On branch ruby2x

• https://github.com/ngiger/oddb.org/commit/d6fa5a2667817a6e6d98c88d74003e7a5ad0acb0 Removed fipdf. Fixed unit tests
• https://github.com/ngiger/oddb.org/commit/1d375cec755a8881e2638543f35dae47ea375ee2 Removed duplicated entries from lnf-base
• pushed tags 1.0.6 and 1.0.7 to https://github.com/ngiger/htmlgrid

htmlgrid branch ruby2x

• https://github.com/ngiger/htmlgrid/commit/a3597828684daf20a4e6567a46a5d26915b99374 Updated to make unit tests pass. Still with LEGACY_INTERFACE
• https://github.com/ngiger/htmlgrid/commit/28deaa817dab4a1c9bea22ad0cb3066d0525cba8 Fixed problem handling nil elements in grid
• https://github.com/ngiger/htmlgrid/commit/8e5af8700ec060316ac3f50290b4d53c1579f6fe Added test for back method

Index

• Remove support for reading PDF and make unit test pass under Ruby 2.x
• Cleanup fachinfo-rss

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Import via data/medreg_companies.yaml
• Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
• Fix galenic_forms when parsing swissmedic.xlsx
• Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
• Get updated ATC-codes from EPha for oddb.org, too.
• Use refdatabase for oddb.org, too.
• Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
• When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
• Order of entering search type and value should not matter. Both should show long URL with search

Remove support for reading PDF and make unit test pass under Ruby 2.x

But first I want to be able to run all unit tests of oddb.org under Ruby 2.x. Must remove references to rpdf2txt.

Discovered that removing LEGACY_INTERFACE in htmlgrid 1.0.7 leads to many problems. Therefore decided to postpone this task till everything is on Ruby 2.0.x. Added tags 1.0.6 and 1.0.7 to ngiger/htmlgrid to have an easy way to see the differences.

Reworking running test for ext, as there were quite a few which I had excluded from. Added two skip, because parsing refdata does not work at the moment.

Must make unit tests for htmlgrid pass for Ruby 1.9.3 and ruby 2.x. Here I found an error that sometimes things get quoted too much, e.g outputs <TD class="css.info">  instead <TD class="css.info">

Pushed commit Updated to make unit tests pass. Still with LEGACY_INTERFACE and waiting whether tests will pass under travis-CI. NO! The tested rubies 2.0.0, 2.1.7, 2.2.3 and ruby-head have different errors, see https://travis-ci.org/ngiger/htmlgrid/builds/98312540. But at least travis 2.2.3 and ruby head have the same errors.

Somehow grid.rb accepts now components with negative offsets. Hope to having it fixed with commit Fixed problem handling nil elements in grid. Okay looks good, travis-CI is green for all variants in build https://travis-ci.org/ngiger/htmlgrid/builds/98321201

Must fix last remaining unit test error in test/test_view/admin/fachinfoconfirm.rb where we get an location.href=&\#39;back&\#39; instead of location.href='back'

Found that there was no unit test for the back procedure in htmlgrid. Added one. Commit is Added test for back method

Had ruby exception when pointing my Gemfile to /opt/src/htmlgrid. Reverting to use :git => 'https://github.com/ngiger/htmlgrid.git', :branch => 'ruby2x' made the problem go away. Waiting for test/suite.rb to finish before uploading my new commit Removed fipdf. Fixed unit tests

One of the nice stuff of ruby 2.x is that it warns me about duplicated entries. Fixed some problems in the lnf base with commit Removed duplicated entries from lnf-base

Cleanup fachinfo-rss

Must remove Lesen Sie die Vollständige Fachinformation auf ODDB.org" from generated RSS, as it makes no longer sense. Running obs/update_textinfo_swissmedicinfo --target=fi with the small patch. Done with commit Removed unused link in fachinfo-RSS