dev.ywesee.com - Niklaus/20160216-fi-parser-use-refdata-names

view · edit · sidebar · attach · print · history

Index>

20160216-fi-parser-use-refdata-names

Summary

Adapt FI-parser to use refdata names for packages

Commits

Index

Adapt FI-parser to use refdata names for packages

Keep in Mind for work to do

Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
Import via data/medreg_companies.yaml
Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
Fix galenic_forms when parsing swissmedic.xlsx
Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
Get updated ATC-codes from EPha for oddb.org, too.
Use refdatabase for oddb.org, too.
Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
Order of entering search type and value should not matter. Both should show long URL with search
Remove parser for minifi (but keep the minifi)

Adapt FI-parser to use refdata names for packages

Continuing work of yesterday. Found the following error

Plugin: ODDB::TextInfoPlugin
Error: NotImplementedError
Message: method `method_missing' called on terminated object (0x000000797f9990 flags=0x0 klass=0x0)
Backtrace:
/var/www/oddb.org/src/model/registration.rb:240:in `packages'
/usr/local/lib/ruby/gems/1.9.1/gems/odba-1.1.0/lib/odba/stub.rb:112:in `method_missing'
/var/www/oddb.org/src/plugin/text_info.rb:1342:in `parse_patinfo'
/var/www/oddb.org/src/plugin/text_info.rb:1496:in `block in import_swissmedicinfo'
/var/www/oddb.org/src/plugin/text_info.rb:1493:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:1493:in `import_swissmedicinfo'
/var/www/oddb.org/src/util/updater.rb:573:in `block in update_notify_simple'
/var/www/oddb.org/src/util/updater.rb:549:in `call'
/var/www/oddb.org/src/util/updater.rb:549:in `wrap_update'
/var/www/oddb.org/src/util/updater.rb:567:in `update_notify_simple'
/var/www/oddb.org/src/util/updater.rb:344:in `update_textinfo_swissmedicinfo'
jobs/update_textinfo_swissmedicinfo:39:in `block in <module:Util>'
/var/www/oddb.org/src/util/job.rb:40:in `call'
/var/www/oddb.org/src/util/job.rb:40:in `run'
jobs/update_textinfo_swissmedicinfo:12:in `<module:Util>'
jobs/update_textinfo_swissmedicinfo:11:in `<module:ODDB>'
jobs/update_textinfo_swissmedicinfo:10:in `<main>'

I think I must use the same trick as in plugin/swissmedic to disable garbage collection in this situation.

Now I must manually decide which barcode belongs to which title for 250 entries.

48869 "Bexin, Hustentabletten" has two different patinfos depending whether it belongs to category B or C. This is something we do not support for the moment. Taking B for the moment.

Don't know how to handle situation with IKSNR 55725 where each (of 20) EAN13 appears twice, e.g.

7680557250023_pi_de: 'Aranesp� Fertigspritze mit automatischem Nadelschutzsystem'
7680557250023_pi_de: 'Aranesp� Fertigspritze'

This looks like not deleting and a wrong entries as we find

  <medicalInformation type="pi" version="2" lang="de" safetyRelevant="false" informationUpdate="04.2009">
    <title>Amavita Sport- und Rheumagel k�hlend</title>
    <authHolder>Amavita Health Care AG</authHolder>
    <authNrs>60024</authNrs>

and

  <medicalInformation type="pi" version="1" lang="de" safetyRelevant="false" informationUpdate="04.2012">
    <title>Dicloren� Gel</title>
    <authHolder>Amavita Health Care AG</authHolder>
    <authNrs>60024</authNrs>

Same here

  <medicalInformation type="pi" version="2" lang="de" safetyRelevant="false" informationUpdate="06.2003">
    <title>AMAphyto Echinacea Tropfen</title>
    <authHolder>Amavita Health Care AG</authHolder>
    <authNrs>63062</authNrs>

and

  </medicalInformation>
  <medicalInformation type="pi" version="1" lang="de" safetyRelevant="false" informationUpdate="06.2003">
    <title>Amavita Echinacea Tropfen</title>
    <authHolder>Amavita Health Care AG</authHolder>
    <authNrs>63062</authNrs>

Running Attach:reparse_needed.sh.txt again to reparse all problematic IKSNRS. Got an error while importing new patinfo for 63235 Paracetamol Spirig HC� 1000 mg. Analysing it.