Index>

20160502-ydim-html-ruby-2-3

Summary

• Port ydim-html to Ruby 2.3

Commits

• https://github.com/ngiger/ydim-html/commit/8dd64bc319d0b91f29a4481f2b02abb4038f0e34 Change charset 8859->utf-8

Index

• Port ydim-html to Ruby 2.3

Keep in Mind for work to do

• Fix dojo error http://www.sitepen.com/blog/2012/10/31/debugging-dojo-common-error-messages/#forgot-dom-ready
• I removed on May-27 tests for ix_registrationss, fix_sequences, fix_compositions, fix_packages from test/test_plugin/swissmedic.rb,as he could not find any references for them in the src code. Did I erroneously remove stuff when cleaning up the swissmedic import earlier?
• The whole test for older/newer Packages must be adapted to xlsx. One must compare the rows (e.g. by creating csv files) and do the same stuff in xlsx!
• creat gem: task: input=file with ean-codes, standard output show ean-codes + atc-code. Source is Swissmedic Packungen.xlsx or XML.
• Import via data/medreg_companies.yaml
• Fix problem with radioactivatum 99m-technetio when parsing Wirkstoffe
• Fix galenic_forms when parsing swissmedic.xlsx
• Cleanup generic_type. Replace it everywhere by sl_generic_type and adapt code accordingly.
• Get updated ATC-codes from EPha for oddb.org, too.
• Use refdatabase for oddb.org, too.
• Check whether we should revert the part which touche src/plugin/text_info.rb of commit 17af82ba4d76a5838683411b260de265531f9e74. We should improve test/stub/oddbapp.rb to work similar for update/pointer as the real oddbapp. In this case we would have a good Stub for plugins. May we need a different stub when working with plugins (which create/modify/destroy ODDB-Objects), when in most other cases a very simple stub is sufficient.
• When a logged in admin user changes an atc_code of a product, the corresponding atc_class must update its sequences, too.
• Order of entering search type and value should not matter. Both should show long URL with search
• Remove parser for minifi (but keep the minifi)
• BSV-Plugin does not send mail. Is it sending two mails at once?
• remove obsolete pdf_patinfo in model, admin/views

Port ydim-html to Ruby 2.3

Why is "Nächste Rechnung" not displayed correctly? It looks like we are missing in ydim-html code the line ACCEPT_CHARSET = 'UTF-8' found in src/view/form.rb Correcting Content-Type in lib/ydim/html/view/ajax_values.rb and lib/ydim/html/view/htmlgrid.rb from 'text/html; charset=ISO-8859-1' to 'text/html; charset=UTF-8' fixes this problem.

Now adapting Hannes test for creating a customer and an invoice.

Moved all my commits into a separate branch ruby2x. Reverted (using a git push --force) my master branch to commit d0dcc6f61e135a272cd55cfa85d78b84824059f4 from zdvatz/master. Pushed commit Change charset 8859->utf-8

Switching back to my ruby2x-branch. As I don't have a good and quick idea on howto make the watir test committing values via the the stub. I work directly with the database. Now a new created debitor displays correctly the Umlaut. See

Redirecting to https://ydim.oddb-ci2.dyndns.org/de/create_invoice/unique_id/17 does not work as it should. Still displays the customer form and not an invoice form.

Trying to find out why requested URL don't get parsed correctly. Added some debug statements in lib/sbsm/trans_handler.rb. The translate_uri calls correctly simple_parse_uri. This works find for '/' and '/de', but not when calling something like '/de/invoices/unique_id/11'.

Addding debug statements to YDIM::Html::Util::validate key create_debitor ["Neuer Kunde"]

I tried to add a method Session::process analogous to the one in oddb.org to add some debug statements. After adding it, the ydim-html process simply did hang and did not write anything out. Change was introducing the following lines (very similar to those of oddb.org/src/util/session.rb

  def process(request)
    @request_path = request.unparsed_uri
    $stderr.puts "YDIM::Html::Util::Session  process #{@request_path}"
    @process_start = Time.now
    super request
    '' ## return empty string across the drb-border
  end

I will try the following tomorrow:

• Remove the *.so files from htmlgrid
• Use Ruby 2.1 for mod_ruby, the gems, ydim and ydim-html
• Test whether mod_ruby 2.1 works with shared libraries disabled and enabled