Index>

20170725-sandoz-transfer-encoding

Summary

• Uploading a transfer dat with encoding 8859-1 failed
• ODDB.org: Merge rack branch into master
• rapflag problems
• Keep in Mind

Commits

• https://github.com/ngiger/bbmb/commit/bc94bf14cccc1b475b3b9eb21d117396aefb77c4 Create new product if only pharmacode is giving and none exists
• https://github.com/ngiger/bbmb/commit/46ce671c3673ae7df6a31f4aea296ed01e6c3bed Handle transfer.dat with ISO 8859-1 encoding
• https://github.com/ngiger/bbmb/commit/8edaae58a7b4afa8db95c31c0dd7b725dc940422 Bump version to 2.3.3
• https://github.com/ngiger/bbmb/commit/a8aff0e1720f80843f36566c6bb7108e08bab887 Fixed unit tests by using persistence/none
• https://github.com/ngiger/bbmb/commit/c09821c3a9feb8b4342c57cd575ce49f35bfa2df Cleanup odba_store. Simplyfied test_server
• https://github.com/ngiger/bbmb/commit/7933fd8f929ecd447cf41170bbc00c17a45dbcf8 Use correct sprintf formatter
• https://github.com/ngiger/sandoz.bbmb/commit/765ab17398822af7ce1bd2ec95028c849821a90d Use BBMB 2.3.3
• https://github.com/ngiger/sandoz.bbmb/commit/004e195915119cfaa93a7cb0d05a83175819e3b4 As sandoz.bbmb.ch is an application remove gemspec
• https://github.com/ngiger/sandoz.bbmb/commit/9579e135e47b9f88bfe60af48e505560b4e288c5 Only test with Ruby 2.4.0 (and head)
• https://github.com/ngiger/sandoz.xmlconv.bbmb.ch/commit/1c731583a3a4f725eb260e098eab88f99e817da7 Use BBMB 2.3.3, SBSM 1.5.6
• https://github.com/ngiger/oddb.org/commit/8a8de82d3cbc33705b060965c8974ac5368e3f70 Merge branch 'rack' of github.com:zdavatz/oddb.org into rack
• https://github.com/ngiger/oddb.org/commit/54a0446d4b16a55061aa359d7448a9a270c62545 Use /var/www/oddb.org again for apache.conf
• https://github.com/ngiger/rapflag/commit/9295fef854a1a79dee479b6242170b382aa9abd2 Create correct entries for intermediate dates
• https://github.com/ngiger/rapflag/commit/9ab0c9cffe39df74dc3b04660bac9f98cccf9dc2 Fix failing unit test

Index

• Uploading a transfer dat with encoding 8859-1 failed
• ODDB.org: Merge rack branch into master
• rapflag problems

Uploading a transfer dat with encoding 8859-1 failed

A client tried to upload transfer_leima_iso_8859-1.dat, which failed. Saving the file locally and testing. It was easy to add it as a unit test in test/util/test_transfer_dat.rb of the bbmb gem and produces the same error.

Pushed the commits

• Create new product if only pharmacode is giving and none exists
• Handle transfer.dat with ISO 8859-1 encoding
• Bump version to 2.3.3
• Use BBMB 2.3.3
• Use BBMB 2.3.3, SBSM 1.5.6

Sandoz.bbmb.ch is an application. Therefore we should not release it as a gem, but use only the Gemfile and the Gemfile.lock. Done with commit As sandoz.bbmb.ch is an application remove gemspec

Remarked that I had not activated the travis-ci. Therefore pushed a small commit Only test with Ruby 2.4.0 (and head)

Now I want to fix the unit tests for BBMB as some no longer work since I moved to use the rack based SBSM. Done with commit Fixed unit tests by using persistence/none

Finished cleanup of unit test with commits

• Cleanup odba_store. Simplyfied test_server
• Use correct sprintf formatter

The wrong formatter to sprintf is only flagged by ruby-head not 2.4.0.

ODDB.org: Merge rack branch into master

Pushed commit Merge branch 'rack' of github.com:zdavatz/oddb.org into rack.

Must fix apache.conf to use /var/www.oddb.org again. Done with Use /var/www/oddb.org again for apache.conf

Adapted the /services/ch.oddb*/run to use /var/www/oddb.org and restarted them.

rapflag problems

Must fix the problem with ZEC,2017.03.24,0.0,285.39429918999997. This should be fixed with commit Create correct entries for intermediate dates and the corresponding unit test with Fix failing unit test