ODBA::Stub was unable to replace Array#36021527 from Hash:#35990969
in /var/www/oddb.org/log/2017/07/26/user_log
settlement
Release 1.0.1 with the improvements of yesterday with commit Prepare version 1.0.1
We still have the problem with XRP which does not have an ending balance for each calendar day and has values that make no sense.
We must figure out the source of the errors by looking into the primitive data downloaded by the API and manually seeing what the ending balalnces should be for the days in which a discrepancy exists. The fourth column in each PrintScreen is the manually-confirmed end-of-day balances.
The source of the error in the XRP ledger is that we are skipping the line containing "SETTLEMENT", which I have contacted support to find out exactly what it means. Will keep posted - the debit should most likely be classified as INCOME.
Note that Bitfinex has introduced a Withdrawal Fee when sending out BTC. Please make sure the code reads this debit as INCOME.
The balances should look like this
currency date total_income total_balance should_be_balance
USD,2017.05.22,36.54801649,49430.15351109 5353.142 USD,2017.05.23,51.365938899999996,63697.13921385 2961.148 USD,2017.05.24,79.68366628999999,71457.80199957 3444.003 USD,2017.05.25,102.62499224999999,83654.62509572999 7676.276 BTC,2017.05.21,0.03492624,58.209182850000005 BTC,2017.05.22,0.03423883,48.05849463 0.5 BTC,2017.05.23,0.02969348,42.63179616 0.98258 BTC,2017.05.24,0.02877522,40.07039899 1.5 BTC,2017.05.25,0.02302126,33.14433381 2.933459 BTC,2017.05.26,0.02068151,33.165015319999995 ZEC,2017.05.22,0.01663624,43.9087342 ZEC,2017.05.23,0.01663624,17.93605074 10.18922 ZEC,2017.05.24,0.01163272,17.94768346 XRP,2017.05.23,-8.20209974,8193.89763759 makes_no_sense as no data XRP,2017.05.24,0.0,8193.89763759 makes_no_sense as no data
Edit to track these problems I implemented also a dump_history for bitfinex when passing the --dump
option.
Pushed
The real work is done with https://github.com/ngiger/rapflag/commit/d482cede9c7e584daf6c3b09582ba1e1276783eb Correct calculation of balance for total files. Consider settlement
Pushed commit Prepare version 1.0.2 and released version 1.0.2
Pushed
Stacktrace is
Encoding::UndefinedConversionError: "\xE4" from ASCII-8BIT to UTF-8 /var/www/oddb.org/src/view/chapter.rb:29:in `encode' /var/www/oddb.org/src/view/chapter.rb:29:in `formats' /var/www/oddb.org/src/view/chapter.rb:140:in `block in paragraphs' /var/www/oddb.org/src/view/chapter.rb:134:in `collect' /var/www/oddb.org/src/view/chapter.rb:134:in `paragraphs' /var/www/oddb.org/src/view/chapter.rb:126:in `block (2 levels) in sections' /usr/local/ruby-2.4.0/lib/ruby/2.4.0/cgi/html.rb:55:in `nO_element' /usr/local/ruby-2.4.0/lib/ruby/2.4.0/cgi/html.rb:62:in `nO_element_def' /var/www/oddb.org/src/view/chapter.rb:112:in `block in sections' /var/www/oddb.org/src/view/chapter.rb:111:in `collect' /var/www/oddb.org/src/view/chapter.rb:111:in `sections' /var/www/oddb.org/src/view/drugs/minifi.rb:30:in `to_html'
Fixed with commit Fix encoding in minifi