20171031-oddb-redesign
Summary
- oddb.org needs some minor redesign
- Keep in Mind
Commits
Index
oddb.org needs some minor redesign
Welcome text should be placed at the top of the page. Ihave problems to add an empty element to the left. A possible solution with logged in looks like this:
But when not logged in it looks like this
Partially worked around this issue by returning a non-breaking space if nobody is logged in. The entity returned also has the CSS-class 'personal', but I did not manage to attache a width of 33% via the CSS.
Creating the preliminary patch. Reworked. Adding width=33% to the td.logo, td.home_welcome and td.personal, fixed the alignment problem.
Saved preliminary patch as Attach:0001-Show-welcome-on-left-patch.txt
Working on the removing FI-Erweitert search. This looks to be quite simple. Running unit and watir tests to see, whether everything is still working okay. The unit tests show that there are no longer any calls to custom_tab_navigation. This must be investigated.
The watir test show the following 67 failures
rspec ./spec/doctors_spec.rb:64 # ch.oddb.org check doctors rspec ./spec/evidentia_spec.rb:209 # ch.oddb.org should work all the time for Cellcept when evidenita LNF is not enabled rspec ./spec/homepage_spec.rb:29 # ch.oddb.org should have a link the various OS variant of AmiKo rspec ./spec/interactions_spec.rb:267 # ch.oddb.org should show interactions for epha example medicaments added manually rspec ./spec/interactions_spec.rb:276 # ch.oddb.org after delete all drugs a new search must be possible rspec ./spec/interactions_spec.rb:289 # ch.oddb.org after adding a single medicament there should be no ',' in the URL rspec ./spec/paypal_spec.rb:86 # ch.oddb.org should be possible to checkout oddb.csv via paypal rspec ./spec/pharmacies_spec.rb:52 # ch.oddb.org check pharmacy rspec ./spec/searchbar_spec.rb[1:1] # ch.oddb.org should be possible to find 1,25-Dihydroxycholecalciferol when searching via 125Dihydroxycholecalciferol 1000 in analysen rspec ./spec/searchbar_spec.rb[1:2] # ch.oddb.org should be possible to find 1,25-Dihydroxycholecalciferol when searching via 125Dihydroxycholecalciferol in analysen rspec ./spec/searchbar_spec.rb[1:3] # ch.oddb.org should be possible to find CA 125 when searching via 125 in analysen rspec ./spec/searchbar_spec.rb[1:4] # ch.oddb.org should should work (58868 Actemra) with Unerw.Wirkungen and Kopfschmerzen rspec ./spec/searchbar_spec.rb[1:5] # ch.oddb.org should should work (58868 Actemra) with Dos./Anw. and Kinder rspec ./spec/searchbar_spec.rb[1:6] # ch.oddb.org should should work (58868 Actemra) with Interakt. and Tocilizumab rspec ./spec/searchbar_spec.rb:116 # ch.oddb.org should should be possible to add and delete several drugs: rspec ./spec/searchbar_spec.rb:135 # ch.oddb.org should should be possible to delete all drugs: rspec ./spec/searchbar_spec.rb:165 # ch.oddb.org should be possible to find Dr. Peter Schönbucher via doctors rspec ./spec/searchbar_spec.rb:205 # ch.oddb.org should be possible to find the Kantonsspital Glarus via Spital rspec ./spec/searchbar_spec.rb:217 # ch.oddb.org should be possible to find Krücke via MiGeL rspec ./spec/searchbar_spec.rb:229 # ch.oddb.org should be possible to find Novartis via Zulassungsinhaber rspec ./spec/searchbar_spec.rb:285 # ch.oddb.org should show only ATC-Code for C01EB10 for Adenosin rspec ./spec/searchbar_spec.rb:299 # ch.oddb.org should show no drugs for Gentamycin in combined search rspec ./spec/searchbar_spec.rb:309 # ch.oddb.org should show no drugs for Gentamycin in price search rspec ./spec/searchbar_spec.rb:319 # ch.oddb.org should show no drugs for Iscover rspec ./spec/searchbar_spec.rb:329 # ch.oddb.org should show no drugs for Fortex in combined search rspec ./spec/searchbar_spec.rb:339 # ch.oddb.org should show no drugs for Fortex via unwanted effects search rspec ./spec/searchbar_spec.rb:351 # ch.oddb.org should be possible to find Budenofalk and Budesonid Sandoz via combined search rspec ./spec/searchbar_spec.rb:381 # ch.oddb.org should search via pharmacode 6430210 without problem rspec ./spec/searchbar_spec.rb:393 # ch.oddb.org should set best_result when searching Rivoleve via search_type rspec ./spec/searchbar_spec.rb:407 # ch.oddb.org should link to the correct ATC-code for Deponit rspec ./spec/smoketest_spec.rb:73 # ch.oddb.org admin admin should edit registration info rspec ./spec/smoketest_spec.rb:199 # ch.oddb.org desitin should have a link to the migel rspec ./spec/smoketest_spec.rb:212 # ch.oddb.org desitin should have a link to the extended search rspec ./spec/smoketest_spec.rb:224 # ch.oddb.org desitin should find redirect an iphone to the mobile flavor rspec ./spec/smoketest_spec.rb:295 # ch.oddb.org desitin should open a sequence specific patinfo rspec ./spec/smoketest_spec.rb:302 # ch.oddb.org desitin should open a package specific patinfo rspec ./spec/smoketest_spec.rb:313 # ch.oddb.org desitin should show correct Tramal Tropfen Lösung zum Einnehmen mit Dosierpumpe (4788/01/035) rspec ./spec/smoketest_spec.rb:323 # ch.oddb.org desitin should show correct Tramal Tropfen Lösung zum Einnehmen ohne Dosierpumpe(4788/01/086) rspec ./spec/smoketest_spec.rb:433 # ch.oddb.org desitin should display the correct calculation for Bicalutamid Actavis rspec ./spec/smoketest_spec.rb[1:2:31] # ch.oddb.org desitin should have a working instant search for Inderal and going back rspec ./spec/smoketest_spec.rb:535 # ch.oddb.org desitin should not display expired drugs, when search says active drugs only rspec ./spec/smoketest_spec.rb[1:2:38] # ch.oddb.org desitin limiting the search to search_limitation_A using Fosfolag rspec ./spec/smoketest_spec.rb[1:2:39] # ch.oddb.org desitin limiting the search to search_limitation_B using Allergo-X rspec ./spec/smoketest_spec.rb[1:2:40] # ch.oddb.org desitin limiting the search to search_limitation_C using Allergo-X rspec ./spec/smoketest_spec.rb[1:2:41] # ch.oddb.org desitin limiting the search to search_limitation_D using Elmex rspec ./spec/smoketest_spec.rb[1:2:42] # ch.oddb.org desitin limiting the search to search_limitation_E using Holunder rspec ./spec/smoketest_spec.rb[1:2:43] # ch.oddb.org desitin limiting the search to search_limitation_SL_only using Soolantra 10 mg rspec ./spec/smoketest_spec.rb[1:2:44] # ch.oddb.org desitin limiting the search to search_limitation_SL_only using Methotrexat rspec ./spec/smoketest_spec.rb[1:2:45] # ch.oddb.org desitin limiting the search to search_limitation_SL_only using mephadolor rspec ./spec/smoketest_spec.rb[1:2:46] # ch.oddb.org desitin limiting the search to search_limitation_SL_only using Omeprazol MUT Sandoz rspec ./spec/smoketest_spec.rb:603 # ch.oddb.org desitin should display a result for homeopathy Similasan Arnica rspec ./spec/snapback_spec.rb:78 # ch.oddb.org snapback should always have the correct home link rspec ./spec/snapback_spec.rb:87 # ch.oddb.org snapback should allow going back, then forward rspec ./spec/snapback_spec.rb[1:3] # ch.oddb.org snapback should a working Home button for step 2 rspec ./spec/snapback_spec.rb[1:4] # ch.oddb.org snapback should a working Home button for step 3 rspec ./spec/snapback_spec.rb[1:5] # ch.oddb.org snapback should a working Home button for step 4 rspec ./spec/snapback_spec.rb:154 # ch.oddb.org snapback should work follow correctly the expected paths rspec ./spec/snapback_spec.rb:182 # ch.oddb.org snapback should work following a fachinfo rspec ./spec/snapback_spec.rb:194 # ch.oddb.org snapback should work following a search via IKSNR rspec ./spec/welcome_spec.rb[1:1] # ch.oddb.org should be possible to see the sponsored log-in in zone analysis rspec ./spec/welcome_spec.rb[1:2] # ch.oddb.org should be possible to see the sponsored log-in in zone pharmacies rspec ./spec/welcome_spec.rb[1:3] # ch.oddb.org should be possible to see the sponsored log-in in zone doctors rspec ./spec/welcome_spec.rb[1:4] # ch.oddb.org should be possible to see the sponsored log-in in zone interactions rspec ./spec/welcome_spec.rb[1:5] # ch.oddb.org should be possible to see the sponsored log-in in zone migel rspec ./spec/welcome_spec.rb[1:6] # ch.oddb.org should be possible to see the sponsored log-in in zone user rspec ./spec/welcome_spec.rb[1:7] # ch.oddb.org should be possible to see the sponsored log-in in zone hospitals rspec ./spec/welcome_spec.rb[1:8] # ch.oddb.org should be possible to see the sponsored log-in in zone companies