< Niklaus.20180205-drugshortage-error | Index | Niklaus.20180130-migel-dateformat >>

20180131-oddb-adsense

Summary

• oddb.org does not display correctly the adsense
• Some FI/PI have a bizare white hole on the right side
• Keep in Mind

Commits

• https://github.com/ngiger/oddb.org/commit/104f30b9fbec7cbef6ffe7bfe3d1922eae8dbcb4 Call new adsbygoogle.js only once. Align righ
• https://github.com/ngiger/oddb.org/commit/ccd4a329a831b9a813c33d2293b1bc03b5640b69 Merge branch 'master' of github.com:zdavatz/oddb.org
• https://github.com/ngiger/oddb.org/commit/6f52d62674995f33ec3250dae04673e7b5e5f258 Adapted test for changes in google_ad_sens
• https://github.com/ngiger/oddb.org/commit/6ed58fddda6ca03ea3e0c222dd84cc36794a6ec0 Fix white hole in patinfo because of too small col_span
• https://github.com/ngiger/oddb.org/commit/acef0b050dc4396186102386571a32059bf01dd6 Avoid nil error when diff info is no longer present

Index

• oddb.org does not display correctly the adsense
• Some FI/PI have a bizare white hole on the right side

oddb.org does not display correctly the adsense

Trying again the async version of google adsense in test9.html. See Attach:test9_html.txt. It displays only

Changing the code and trying it on oddb-ci2. Surrounding (adsbygoogle = window.adsbygoogle || []).push({}); by calls to console.log('Before|After pushing adsbygoogle'); to be able to verify that the code got executed. This displays a very ugly https://oddb-ci2.dyndns.org/de/gcc/search/zone/doctors/search_query/Glarus? where the logo is way too big. Reading the code to limit width/heigth.

Working on making the size and placement correct for home_doctors. Adding different color for left/right and a border.

Trying to replace the ad-format using

-     data-ad-format="autorelaxed"
-     style="display:inline-block"
+     data-ad-format="rectangle"
+     style="display:block"

Found the following remark under https://support.google.com/adsense/answer/3221666?hl=en

If I have multiple ad units on a page, do I have to include <script async src="//pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script> for each ad unit?
No, this is not necessary, adsbygoogle.js can be loaded once.

and

Can I set the size of the ad directly via CSS?
Yes you can, doing so allows you to dynamically specify the size of the ad that will be served.

Checking whether I can use additional_javascripts to load the adsbygoogle.js. Adapted the style to style="display:block height #{@height}px width {@width}px" and now the sizes look okay, but still do not show any images. Conservered state in 0001-Using-async-version-of-google-ad_sense.js.-Debug-28.patch. Removing cruft. After changing the css class from welcomeright to right in src/view/welcomehead.rb all search results are displayed correclty. Also the login screen.

Pushed the following commits

• Call new adsbygoogle.js only once. Align righ
• Merge branch 'master' of github.com:zdavatz/oddb.org
• Adapted test for changes in google_ad_sens

Some FI/PI have a bizare white hole on the right side

Example: https://ch.oddb.org/de/gcc/patinfo/reg/59288/seq/02/pack/006

Should be fixed with commit Fix white hole in patinfo because of too small col_span

Fixed show a rack error when a FI is no longer present with commit Avoid nil error when diff info is no longer present. No it show the correct message, that the desired information is no longer present.