view · edit · sidebar · attach · print · history

< Niklaus.20180212-changelog-problem | Index | Niklaus.20180206-pi-error >>

20180207-lighthouse

Summary

  • Install new dojo version 1.13.0 on thinpower
  • Improve using feedback from lighthouse
  • Keep in Mind

Commits

Index

Install new dojo version 1.13.0 on thinpower

Removing old dojo-version under /var/www/oddb.org/doc/resources.

On thinpower:

/var/www/oddb.org/doc/resources
wget https://download.dojotoolkit.org/release-1.13.0/dojo-release-1.13.0.tar.gz
rm -rf dojo.bak
mv dojo dojo-1.12.1
mv dojo-release-1.13.0 dojo
svc -h /service/ch.oddb-generika
# Checked dojo version on generika.cc
svc -h /service/ch.oddb

Improve using feedback from lighthouse

Zeno wants the following changes

  • Viewport Meta-Tag erstellen, siehe Lighthouse report. <meta name="viewport"> tag with width or initial-scale
  • meta description erstellen für jede Seite von oddb, mit Content: "Open Drug Database Switzerland"
  • kannst Du beim App-Down screen auch die Werbung oben rechts vom Suchresultat einblenden?

For the first two point I pushed commit Add HTML meta tags viewport and description

Removed the doc/resources/errors/logo.png and using resources/gcc/logo.png in th appdown.html.

When I remove doc/resources/errors/appdown.html and the oddb.org service is restarting only the following message is displayed

Service Temporarily Unavailable

The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.

Additionally, a 503 Service Temporarily Unavailable error was encountered while trying to use an ErrorDocument to handle the request.
Apache Server at oddb-ci2.dyndns.org Port 443

For unknown reason a quirk.css was used. Adding a style definition like this

    <style>table {
        font-family : Arial, Helvetica, sans-serif;
        font-size   : 12px;
      }
    </style>

fixed using the same font size as everywhere. Also it made the table use full screen width.

Pushed commit Add adsense in appdown. Fix logo path and Fix unit tests for views

Pushed commit Fix centered logo for mobile lnf

Looking at the lighthouse errors for search by ponstan.

Will write a small helper script to gzip all dojo*.js scripts and placing them at their original place. See Attach:zip_javascript_rb.txt Pushed commits

Must remove the Link to the LGPL for all LNFs.

Must remove all occurrences of "Sie befinden sich". Done with

Ran the bin/zip_javascripts.rb on thinpower. Then ran again lighthouse on search result of ponstan. lighthouse complained about many console errors. Therefore I reverted to use dojo without gzip compression.

As I get quite often errors on travis-ci because of garbage collection issues with the test/test_util/oddb_app*.rb test cases, I started a branch gc_problem adding a GC.start each time before a new test is started.

Loaded https://i.ch.oddb.org/de/gcc/fachinfo/reg/57555 on my MacOSX safari to try to see whether, I get also different font sizes. But no problem showed up.

Looking around why the text size changes on iphone when displaying the FI chapter links.

Found https://developer.mozilla.org/en-US/docs/Web/CSS/text-size-adjust and http://css-infos.net/property/-webkit-text-size-adjust (specifically for Safari). I think we could test once with -webkit-text-size-adjust: none;

Checking why lighthouse reports the following problem

Content is not sized correctly for the viewport
If the width of your app's content doesn't match the width of the viewport, your app might not be optimized for mobile screens. Learn more.
The viewport size is 984px, whereas the window size is 412px.

No idea why lighthouse uses a window size of 412px.

Removing the tundra.css must be done via lib/htmlgrid/dojotoolkit.rb. This improves loading quit a bit.

view · edit · sidebar · attach · print · history
Page last modified on February 07, 2018, at 05:05 PM