20130603-search-tab-navigation-and-old-pi-ebook-title

<< | Index | >>

Summary

• Repair bug in centered search
• Debug and Fix Session Problem (Creation, Expiring and Redirect)

Commits

• Fix bug of multiple requests in search form
• Improve searchbar scripts rendering
• Fix bug of session expiring and redirect

Index

• Repair centered search
• Debug old PI Ebook creation
• Fix session problem

Repair centered search

• Analysen
• Arzt
• Interaktion
• Spital
• Zulassunginhaber

Zone does not work. (@session.zone)

Centered Search form does not send zone

<div style="display:none">
  <input type="hidden" value="gcc" name="flavor">
  <input type="hidden" value="de" name="language">
  <input type="hidden" value="search" id="event" name="event">
  <input type="hidden" value="74606760" name="state_id">
</div>

Form has zone into requste URL. (expected)

This was bug of Search Form.
Form had been send multiple requests. (POST, GET).
In here, POST Request is not needed.

Then, I disabled POST Request in onSubmit.

commit

• Fix bug of multiple requests in search form

And I updated scripts rendering and test case.

commit

• Improve searchbar scripts rendering

% ruby test/test_view/searchbar.rb
could not find htmlgrid.so, falling back to pure-ruby class
Loaded suite test/test_view/searchbar
Started
......

Finished in 0.005505227 seconds.

6 tests, 6 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

1089.87 tests/s, 1089.87 assertions/s

Debug old PI Ebook creation

There are still some old PI does not have title(@name attribute) in Ebook.
Tried with newest data.

Then, I exported again newest PIs and Generate Ebook, again.

Fix session problem.

Currently, active_state by state_id is mssing for login user.

z.B. Preference State

event	update
flavor	gcc
language	de
search_form	plus
search_type	st_company
state_id	84077800
style	purple
zone	drugs

style=red&search_form=plus&search_type=st_company&flavor=gcc&language=de&event=update&state_id=63500580&zone=drugs

Parameters are fine.

Comment in SBSM::Session#process (Maybe this is also related.)

        #FIXME: is there a better way to distinguish returning states?
        #       ... we could simply refuse to init if event == :sort, but that
        #       would not solve the problem cleanly, I think.

@attendend_states are clead, unexpectedly.
This meas __checkout(logout) method is called by every request for login user.

ODDB::Session

    def expired?(now=Time.now)
      super || (logged_in? && !@user.expired?)
    end

Fixed this bug.

commit

• Fix bug of session expiring and redirect