20160708-migrate-davaz-com-dojo-widgets
<< 20160709-bundle-gems-and-watir-feature-test-davaz-com | Index | 20160707-migrate-davaz-com-dojo-widgets >>
Summary
- Migrate custom dojo widgets and javascript codes to 1.7
Commits / Patches / Pull Requests, Scripts
- Create TransHandler for Zone [commit, davaz.com]
- Fix error by no implicit conversion [commit, davaz.com]
- Avoid error by unexcpected argmument (e.g. Fixnum) [commit, davaz.com]
- Fix date object miss matching error [commit, davaz.com]
- Make rack widegt to work with dojo 1.7 [commit, davaz.com]
- Improve htmr attribute name in Ticker template [commit, davaz.com]
- Fix toggleShow function [commit, davaz.com]
- Improve slide upside/down show animation [commit, davaz.com]
- Make Desk widget to work [commit, davaz.com]
Index
Dojo Widgets
- Desk.js
- EditButtons.js
- EditWidget.js
- GuestbookWidget.js
- Input.js
- InputText.js
- InputTextarea.js
- LoginWidget.js
- [x] OneLiner.js
- Rack.js
- Show.js
- SlideShow.js
- [x] Ticker.js
- [x] Tooltip.js
SBSM TransHandler
Currently, davaz.com on Ruby 2.3.1 + Dojo 1.7.7 in my local box, sidebar does not work.
It seems that wrong sbsm state comes.
This cased by switch_zone.
- zone -> x
- event -> ok
New htmlgrid requires sbsm >= 1.2.7. The current production davaz.com use sbsm 1.2.3.
I think this difference is key.
This change could affect davaz.com as this problem.
Hmm, But I'm not sure about this...
commit ab9b4e4537ca06cabdc528e01d55cb95663767b9
Author: Niklaus Giger <ngiger@ywesee.com>
Date: Mon Apr 25 15:20:43 2016 +0200
All unit tests pass now under Ruby 2.3.0
diff --git a/lib/sbsm/trans_handler.rb b/lib/sbsm/trans_handler.rb
--- a/lib/sbsm/trans_handler.rb
+++ b/lib/sbsm/trans_handler.rb
@@ -81,68 +84,56 @@
- values.add(name, ast.send(name).value)
+# values.add(name, ast.send(name).value)
when 'variables'
Finaly, I've found a problem
% ./run-dvzd.sh
could not find htmlgrid.so, falling back to pure-ruby class
active_state
DAVAZ::Util::Session
DAVAZ::State::Personal::Init
{:language=>"en", :event=>:drawings, :default_flavor=>nil, :flavor=>"works"} #=> This is `@valid_input`
davaz.com does not use flavor, but sbsm thinks works as flavor. It must be ZONE.
SBSM
;; lib/sbsm/session.rb
def import_user_input(request)
# attempting to read the cgi-params more than once results in a
# DRbConnectionRefused Exception. Therefore, do it only once...
return if(@user_input_imported)
request.params.each { |key, value|
=> puts "importing #{key} -> #{value}"
index = nil
...
importing language -> en importing event -> drawings importing default_flavor -> importing flavor -> works
ZoneTransHandler is missing...
FlavoredTransHandler and ZoneTransHandler are already removed by commit above.
But it seems that davaz.com needs still this grammer (data/zone_uri.grammer)
;; by same commit above
- class FlavoredTransHandler < AbstractTransHandler
- include Singleton
- def initialize
- super('flavored_uri')
- end
- end
- class ZoneTransHandler < AbstractTransHandler
- include Singleton
- def initialize
- super('zone_uri')
- end
- end
I've heard from Zeno-san that these (old) special Transhandlers by using Rockit were already removed.
So, And I've decieded to write owned TransHandler (like oddb.org) by davaz.com.
Then it works, fine :)
Commit:Create TransHandler for Zone
Rack Widget
Warning from dojo for ajax_image
Consider using the standard mimetype:application/json. json-commenting can introduce security issues. To decrease the chances of hijacking, use the standard the 'json' handler and prefix your json with: {}&&
Use djConfig.useCommentedJson=true to turn off this message.
Rack Widget use ywesee.widget.Show as mixin.
Commit:Make rack widegt to work with dojo 1.7
Widgets
- Desk.js
- EditButtons.js
- EditWidget.js
- GuestbookWidget.js
- Input.js
- InputText.js
- InputTextarea.js
- LoginWidget.js
- [x] OneLiner.js
- [x] Rack.js
- [x] Show.js
- SlideShow.js
- [x] Ticker.js
- [x] Tooltip.js
Next, Desk widget.
Desk Widget
Commits:
