20160810-migrate-davaz-com-remove-warnings-htmlgrid

<< 20160815-migrate-davaz-com | Index | 20160809-migrate-davaz-com-fix-feature-tests >>

---

Summary

• Fixed tooltip state name issue
• Fixed warnings on htmlgrid
• Fixed errors on test on htmlgrid

Commits / Patches / Pull Requests, Scripts

• Fix tooltip state klass name issue [commit, davaz.com]
• Fix warning about using Hash#index [commit, htmlgrid]
• Fix warning tag is not initialized [commit, htmlgrid]
• Fix warning mey is not initialized [commit, htmlgrid]
• Fix test error by rebuild.rb for htmlgrid.so [commit, htmlgrid]
• Fix warning attributes method is redefined [commit, htmlgrid]
• Fix warning tag= method is redefined [commit, htmlgrid]
• Fix warning mismatch indentations [commit, htmlgrid]
• Fix warning mismatch indentation [commit, htmlgrid]
• Fix warning mismatch indentation [commit, htmlgrid]
• Fix warning model is redefined [commit, htmlgrid]
• Fix test_composite warnings [commit, htmlgrid]
• Fix warning htmlgrid.so (it's already gone) [commit, htmlgrid]
• Fix warnings on test_composite.rb [commit, htmlgrid]
• Fix warning unused variable e [commit, htmlgrid]
• Fix warning unused variable result [commit, htmlgrid]
• Fix test_interaction_list warnings [commit, htmlgrid]
• Fix argument error for foo method at test_add_row [commit, htmlgrid]
• Fix html attribute order [commit, htmlgrid]
• Fix warnings and errors on test [pull request, htmlgrid]
  • Add Gemfile.lock as ignore
  • Add a email notification recipient
  • Remove heredoc syntax for ruby 2.3.1
  • Fix ruby 2.1.9 and 2.0.0 installation issue
  • Add ruby 2.3.1 as ci target
  • Add .ruby-version as git ignore
  • Fix asset files
  • Bump version to 1.1.2

Index

• Fix tool select option
• Fix tooltip state name error
• Remove warnings from htmlgrid
• Fix sbsm shadowing warning

---

Fix tool select option

See http://dev.ywesee.com/Yasu/20160808-migrate-davaz-com-fix-feature-tests#fix-tool-select-option

It seems that this is fixed... Why?
All ajax requests for new art object are fine. I can't see this error anymore :)

Fix tooltip state name error

NameError
uninitialized constant DaVaz::State::Tooltip::Global
Did you mean?  DaVaz::State::Global

Commits:

• Fix tooltip state klass name issue

Remove warnings from htmlgrid

At errormessage

/path/to/ruby/2.3.0/gems/htmlgrid-1.1.1/lib/htmlgrid/errormessage.rb:64: warning: Hash#index is deprecated; use Hash#key

[1] 2.3.1-p112(main)> h = { "a" => 100 }
=> {"a"=>100}
[2] 2.3.1-p112(main)> h.index(100)
(pry):2: warning: Hash#index is deprecated; use Hash#key
=> "a"
[3] 2.3.1-p112(main)> h.key(100)
=> "a"

Commits:

• Fix warning about using Hash#index

At boot

could not find htmlgrid.so, falling back to pure-ruby class

Commits:

• Fix warning htmlgrid.so (it's already gone)

Fix htmlgrid test errors and warnings

Currently in Ruby 2.3.1, htmlgrid's test fails with errors and warninngs.
Then I will fix this. (test failures are ok for now.)

@tag is not initialized

/path/to/htmlgrid/lib/htmlgrid/grid.rb:115: warning: instance variable @tag not initialized
/path/to/htmlgrid/lib/htmlgrid/grid.rb:115: warning: instance variable @tag not initialized
/path/to/htmlgrid/lib/htmlgrid/grid.rb:115: warning: instance variable @tag not initialized
...

Commits:

• Fix warning tag is not initialized

@mey is not initialized

/path/to/htmlgrid/test/test_label.rb:75: warning: instance variable @mey not initialized

Commits:

• Fix warning mey is not initialized

attributes method is redefined

/path/to/htmlgrid/test/test_list.rb:37: warning: method redefined; discarding old attributes

Commits:

• Fix warning attributes method is redefined

session variable is not used

/path/to/htmlgrid/lib/htmlgrid/composite.rb:108: warning: assigned but unused variable - session

Commits:

• Fix warning session variable is not used

test suite fails by rebuild.rb

C extension htmlgrid.so is already gone. But test suite.rb require rebuild.rb which is support file to load htmlgrid.so.

Commits:

• Fix test error by rebuild.rb for htmlgrid.so

tag= method is redefined

/path/to/htmlgrid/lib/htmlgrid/grid.rb:112: warning: method redefined; discarding old tag=

Commits:

• Fix warning tag= method is redefined

mismatch indentations at grid.rb

/path/to/htmlgrid/lib/htmlgrid/grid.rb:211: warning: mismatched indentations at 'end' with 'if' at 195

Commits:

• Fix warning mismatch indentations

mismatch indentations at component.rb

/path/to/htmlgrid/lib/htmlgrid/component.rb:218: warning: mismatched indentations at 'end' with 'def' at 216

Commits:

• Fix warning mismatch indentation

mismatch indentations at labal.rb

/path/to/htmlgrid/lib/htmlgrid/label.rb:80: warning: mismatched indentations at 'end' with 'if' at 77

Commits:

• Fix warning mismatch indentation

model method is redefined

/path/to/htmlgrid/test/test_component.rb:34: warning: method redefined; discarding old model

Commits:

• Fix warning model is redefined

mismatch indentations at test_composite.rb

/
path/to/htmlgrid/test/test_composite.rb:203: warning: mismatched indentations at 'end' with 'def' at 195

Commits:

• Fix test_composite warnings

container= method is redefined

/path/to/htmlgrid/test/test_composite.rb:37: warning: method redefined; discarding old container=

Commits:

• Fix warnings on test_composite.rb

unused variable e

/path/to/htmlgrid/lib/htmlgrid/list.rb:157: warning: assigned but unused variable - e

Commits:

• Fix warning unused variable e

unused variable result

/path/to/htmlgrid/test/test_grid.rb:338: warning: assigned but unused variable - result

Commits:

• Fix warning unused variable result

container= method is redefined (at test_interaction)

/path/to/htmlgrid/test/test_interaction_list.rb:20: warning: method redefined; discarding old container=

Commits:

• Fix test_interaction_list warnings

@mey is not initialized

/path/to/htmlgrid/test/test_label.rb:79: warning: instance variable @mey not initialized

Commits:

• Fix warning mey is not initialized

@drugs is not initialized

/path/to/htmlgrid/test/test_interaction_list.rb:138: warning: instance variable @drugs not initialized

Commits:

• Fix warning drugs is not initialized

Argument Error at test_add_row.rb

  2) Error:
TestComposite#test_to_html:
ArgumentError: wrong number of arguments (given 2, expected 1)
  /path/to/htmlgrid/test/test_add_row.rb:27:in `foo'
  /path/to/htmlgrid/lib/htmlgrid/composite.rb:68:in `create'
...

Commits:

• Fix argument error for foo method at test_add_row

Fix test failure by html attribute order

    if RUBY_VERSION.split(".").first.eql?('1')                                  
      expected << 'OPTION value="foobar" selected>Foo Nr. 2</OPTION'            
    else                                                                        
      expected << '<OPTION selected value="foobar">Foo Nr. 2</OPTION>'          
    end

It seems that curretly in both ruby (1, 2) option tag is created as <option value="..." selected></option>

Commits:

• Fix html attribute order

Fix sbsm shadowing warning

/path/to/htmlgrid/.bundle/gems/ruby/2.1.0/gems/sbsm-1.3.0/lib/sbsm/lookandfeel.rb:69: warning: shadowing outer local variable - args

Continue tomorrow.