view · edit · sidebar · attach · print · history

20130820-wrong-patinfo4

<< | Index | >>


Summary

  • We need to compare the expected IKSNRS for a PI/FI with the ones in the XML document

Commits

Index


We need to compare the expected IKSNRS for a PI/FI with the ones in the XML document

  • Added a helper funktion get_pis_and_fis which fills hashes @fis_to_iksnrs and @pis_to_iksnrs with the values found the in XML document.

Comparing the /proc/<id>/status with and without the new function I found out that it added about 4,2 to 960 MB needed memory (VmSize), which I considered a good use. Filling in the values takes less than 5 seconds + reading the XML file. Time to add the helper function to src/plugin/text_info.r.b

I need some more changes to get the update jobs pass. Found many roblesm with the following ids:

name='14272 16380 16522 19625 24926 24959 28840 29729 29730 30433 34370 35279 35532 35709 35921 35922 36110 36111 36575 37867 38096 38359 38423 39205 39254 39622 40226 40414 40558 41125 41217 41903 42083 42084 42125 42823 43216 43225 43522 43593 43779 43869 43870 44146 44371 44372 44939 45275 45276 45277 45427 45428 45674 45859 46429 46489 46619 46620 46621 46898 47915 48057 49156 49182 49783 50262 50556 52377 52557 52558 52559 52560 52594 52866 53493 53841 53978 53979 54068 54260 54268 54331 54393 54447 54541 54785 54810 54948 54984 55262 55295 55431 55656 55666 55667 55811 55841 56056 56075 56328 56381 56750 56882 57459 57566 57567 57660 57740 58416 58417 58436 58939 59189 59190 60131 60443 60513 60514 60590 60591 60592 60593 60594 60595 60597 60598 60599 60600 60601 60602 60603 60604 60605 60606 60607 60608 60609 60610 60611 60621 60623 60624 60625 60626 60627 60628 60629 60630 60631 60632 60633 60634 60635 60636 60637 60638 60639 60640 60641 60642 60838 60839 60840 60843 60856 60858 60870 60873 60880 60886 60889 60904 60906 60911 60912 61216 61263 61318 61531 61671 61672 61673 61690 61693 61725 61728 61731 61733 61735 61797 61799 61812 61818 61835 61837 61845 61846 61847 61860 62067 62391 62569 62714 62726 62727 62746 62848 62973'

See also console as Attach:console.txt. There we find 28 occurences of inconsistent_pi_iksrns and 146 of inconsistent_fi_iksrns. Deleted 28 patinfos. Started to import 230 unique iksnrs, but failed after 3 or 4 imports, when importing the first patinfo. There must be an error in my passing the iksnrs from the xml to the patinfo.

Now my import works, but at the end I get the following error

Plugin: ODDB::TextInfoPlugin
Error: NotImplementedError
Message: method `method_missing' called on terminated object (0x007fea7fac9dd0 flags=0x0 klass=0x0)
Backtrace:
/var/www/oddb.org/src/plugin/text_info.rb:99:in `block in replace'
/var/www/oddb.org/src/plugin/text_info.rb:98:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:98:in `replace'
/var/www/oddb.org/src/plugin/text_info.rb:160:in `block in update_fachinfo'
/var/www/oddb.org/src/plugin/text_info.rb:152:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:152:in `update_fachinfo'
/var/www/oddb.org/src/plugin/text_info.rb:950:in `parse_and_update'
/var/www/oddb.org/src/plugin/text_info.rb:961:in `block (3 levels) in import_info'
/var/www/oddb.org/src/plugin/text_info.rb:960:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:960:in `block (2 levels) in import_info'
/var/www/oddb.org/src/plugin/text_info.rb:959:in `each_pair'
/var/www/oddb.org/src/plugin/text_info.rb:959:in `block in import_info'
/var/www/oddb.org/src/plugin/text_info.rb:956:in `each_pair'
/var/www/oddb.org/src/plugin/text_info.rb:956:in `import_info'
/var/www/oddb.org/src/plugin/text_info.rb:1152:in `block in import_swissmedicinfo_by_iksnrs'
/var/www/oddb.org/src/plugin/text_info.rb:1144:in `each'
/var/www/oddb.org/src/plugin/text_info.rb:1144:in `import_swissmedicinfo_by_iksnrs'
/var/www/oddb.org/src/plugin/text_info.rb:1122:in `block in update_swissmedicno_fi_pi'
was at
3708:update_fachinfo Cerzin-Mephaź 10 Lactab/Tropfen iksnr ["56882", "56381"]
3709:update_fachinfo Cerzin-Mephaź 10 Lactab/Tropfen iksnr 56882 store_fachinfo {}
3710:update_fachinfo Cerzin-Mephaź 10 Lactab/Tropfen iksnr 56381 store_fachinfo {}

We seem to have problems handling the following error check_swissmedicno_fi_pi inconsistent_fi_iksrns ["56882", ["56882"], "fi-iksnrs should match", ["56381", "56882"]]. It means that it si possible to use one FI for two iksnrs, but we have two old ones. I could skip updating this and leave the old ones.

Trying to update the fachinfo.iksnrs is not so simple. Therefor I will flag the errors for the time being. Must have later a look at src/state/admin/fachinfoconfirm.rb to see how to handle the situation correctly.

Had a similar error importing the patinfo, because of a misplaced if/then/else.

ch.oddb> registration('62569').fachinfo.name_base
-> Candesartan Takeda 4 mg
ch.oddb> registration('62569').fachinfo.iksnrs
-> ["62569", "54260"]
ch.oddb> 
view · edit · sidebar · attach · print · history
Page last modified on August 20, 2013, at 05:10 PM