view · edit · sidebar · attach · print · history

< Niklaus.20180228-gtin | Index | Niklaus.20180213-doctor-Encoding-CompatibilityError >>





Fix Layout Issue on Safari

In drugs home the red/green lines do not go to the right end. This happens with all browser, when visiting FI/PI changelogs like

This should be fixed with commit We don't need a colspan map for change_logs

Improve using feedback from lighthouse

Will try to measure the difference between using zipped version of dojo an unzipped ones.

Here the main results for by lighthouse with the unzipped version.

  • Performance 71
  • Progressive Web App 45
  • Accessibility 62
  • Best Practices 81
  • SEO 89
  • First meaningful paint 3,450 ms
  • First Interactive (beta) 6,200 ms
  • Reduce render-blocking scripts 2,040 ms dojo.js, Enable text compression 1,57 ms

Removing manually the tundra.css in vendor/ruby/2.5.0/gems/htmlgrid-1.1.4/lib/htmlgrid/dojotoolkit.rb to see the difference.

What lighthouse does not report, but is clearly visible, that it take many seconds till finishes.

Zipping the javascript using

sudo /etc/init.d/apache2 restart
sudo svc -h /service/ch.oddb*

Now measuring again.

  • Performance 79
  • Progressive Web App 45
  • Accessibility 49
  • Best Practices 75
  • SEO 89
  • First meaningful paint 2,840 ms
  • First Interactive (beta) 5,31 ms

It still says that we could save space in dojo.js (but reports it correctly as being 58,4 kB wherease before it was > 500 kB). Also it says we could also compress the CSS files.

But debugging or seeing the correct javascript is now impossible in the developper tools.

Compressing the css files, too. Now performaces raises to 83.

Running watir-smoketest. Fixed it with commit

Pushed commit to zip CSS and JS files Zip CSS and JS files

Now installing the zipped file on thinpower.

cd /var/www/
tar -xf dojo-release-1.13.0.tar.gz
ywesee@thinpower /var/www/ $ ../../bin/zip_javascripts.rb dojo-release-1.13.0
Directory dojo-release-1.13.0: Found 7430 .js-files to zip
Directory dojo-release-1.13.0: Found 1201 .css-files to zip
sudo svc -d /service/ch.oddb*
rm -rf dojo
mv dojo-release-1.13.0 dojo
sudo /etc/init.d/apache2 restart
sudo svc -u /service/ch.oddb*

Running the whole watir tests against the zipped version on oddb-ci2.

Why do the travis-CI builds sometimes fail, eg.

......S....../home/travis/build/ngiger/ [BUG] rb_gc_mark(): 0x0000000003ab12f8 is T_NONE
ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]
-- Control frame information -----------------------------------------------
c:0026 p:---- s:0145 e:000144 CFUNC  :start
c:0025 p:0371 s:0141 E:000450 METHOD /home/travis/build/ngiger/ [FINISH]
c:0024 p:---- s:0129 e:000128 CFUNC  :new
c:0023 p:0077 s:0124 e:000123 METHOD /home/travis/build/ngiger/
c:0022 p:0010 s:0119 e:000118 BLOCK  /home/travis/build/ngiger/

Pushed commit Try to make running oddbapp tests more robust

Looking how I can deliver dojo.js and/or oddb.css inline via htmlgrid. This is possible, but needs it in two occasions, lib/htmlgrid/dojotoolkit.rb (dynamic_html_headers) and lib/htmlgrid/template.rb (css_link).

Made a first test with the unencrypted CSS file. This worked and speed went up to 89. Trying to use zipped files, too.

UnitTest not yet okay. Saving temporary solution See Attach:htmlgrid_inlining.txt

view · edit · sidebar · attach · print · history
Page last modified on February 14, 2018, at 05:07 PM