20160823-migrate-davaz-com

<< 20160824-migrate-davaz-com | Index | 20160822-debug-product-confusion-sandoz-xmlconv-bbmb-ch-migrate-davaz-com >>

Summary

• Fix artobject form
• Fix gallery

Commits / Patches / Pull Requests, Scripts

• Fix new art object [commit, davaz.com]
• Fix serie link at gallery [commit, davaz.com]
• Fix tooltip on inspiration page [commit, davaz.com]
• Fix desk style [commit, davaz.com]
• Arrange davaz.js [commit, davaz.com]
• Fix ContentPane widget [commit, davaz.com]
• Fix links on movie [commit, davaz.com]
• Enable tooltip on personal work [commit, davaz.com]

Index

• Fix new artobject creation
• Fix serie link on gallery
• Fix inspiration tooltip
• Fix movie link test

Fix new artobject creation

When I save new art object, all artobject's series are confused.
But there is only a single INSERT query. This is strange.

197 Query     INSERT INTO artobjects (location,language,price,serie_position,size,text,url,title,artgroup_id,serie_id,\
tool_id,material_id,date,country_id) VALUES ('','','','','','Foo Bar<br />','','Test','DRA','ACD',\
'10','46','1970-1-1','ARG')

This was problem of application design (data structure design).
serie is not belongs to artgroup. but on view, load all artobjects by serie. This means admin user must care about which serie is used by artgroup. (This is bad).

But, for now, I would like to focus only fixing bad code and migrating to Ruby 2.3.1 and Dojo 1.7.
Then this problem is ignored.

dijit editor (dojo makes iframe) is not testable for now :'(

Commits:

• Fix new art object

Fix serie link on gallery

Commits:

• Fix serie link at gallery

Fix inspiration tooltip

Tooltips on inspiration page do not work.
Because this use dojo_tooltip support on htmlgrid. (this does not work)

I would like to remove dojo support feature from htmlgrid.
Then, I've implemented these tooltips in application.

Commits:

• Fix tooltip on inspiration page

Fix movie link test

davaz.com has many irregular html tags.
z.B

<a href="" onclick="function();" ></a>

Or a Page has same duplicated id attributes.
This is bad.

We cannot run test with this bad style code.
Then I've fixed some these parts for movies.

• Remove duplicated ID
• Use fire_event instead of click on watir (http://www.rubydoc.info/github/watir/watir-classic/Watir/Element#fire_event-instance_method)

Commis:

• Fix links on movie