< Niklaus.20180110-ydim-html-rack | Index | Niklaus.20180108-postgres10 >>
Must commit to change loading the config yaml file early enough. Also Zeno reported that the PDF did still show the old VAT tax of 8.0%. It looks to me that on thinpower the changes introduceed via the commit https://github.com/zdavatz/ydim/commit/fbbc61f8b5f3262583d08ec7ccc7cade4b1c7756 Fixed loading bin/ydimd were not properly propated to thinpower.
Also we find that bin/ydim-edit still defines at https://github.com/zdavatz/ydim/blob/master/bin/ydim-edit#L48 a vat_rate of 8.0. This definition should go into the loaded config /etc/ydim/ydimd.yml. The change of a VAT-rate should NOT need a code change, only a configuration change.
The logo did not display until I added the line logo_path: /etc/pdfinvoice/logo.png /etc/ydim/ydimd.yml, which was previously found in /etc/pdfinvoice/config.yml
Pushed the commits
It is okay to use the new version 0.5.4 of ydbi and yddb-pg.
Had to add the content of /etc/pdfinvoice/config.yml into /etc/ydim/ydimd.yml. Now the invoices work correctly.
The PDF still does not work correctly. In commit https://github.com/ngiger/ydim/commit/5da6e057 the text of the MwSt is set to 7.6 if the VAT-rate of the server at the moment is display is diffent from the VAT-rate at the moment, when the invoice is generated.
Banging my head why we find in the yml files overlapping and contradictory definitions like
I will fix this mess by using always the vat_rate and use a tax_print_format 'MwSt %0.1'. (Note: Zeno is happy to use the same MwSt for all invoices. This is an assumption that is wrong if some lines would have a VAT of 0 or a reduced VAT and others the normal VAT rate.
Corrected some issues in ydim. Now the generated PDF shows and uses the correct VAT-rate of 7.7. https://ydim.ywesee.com/de/ydim/invoice/unique_id/12653 however still displays "MwSt 8.0". This comes from the definition inside lib/ydim/html/util/lookandfeel.rb. This must be reworked, too.
Pushed commits
When sending emails I must show all recipients (to, cc and bcc).
Working on fixing the error reported yester when running import_daily.